writeas/go-writeas
1
0
Fork 0
mirror of https://github.com/writeas/go-writeas.git synced 2025-07-27 19:59:02 +00:00
Code Issues Releases Activity

Revert "DeleteCollection: Make params a struct"

Browse Source 
This reverts commit 1d34eede72.
This commit is contained in:
Matt Baer 2019-05-26 14:08:05 -04:00
parent 1d34eede72
commit 7a2c93ae6d
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
collection.go
View File

@ -29,12 +29,6 @@ type (
Alias string `json:"alias"`
Title string `json:"title"`
}
// DeleteCollectionParams holds the parameters required to delete a
// collection.
DeleteCollectionParams struct {
Alias string `json:"-"`
}
)
// CreateCollection creates a new collection, returning a user-friendly error
@ -146,8 +140,8 @@ func (c *Client) GetUserCollections() (*[]Collection, error) {
// anonymous.
//
// See https://developers.write.as/docs/api/#delete-a-collection.
func (c *Client) DeleteCollection(p *DeleteCollectionParams) error {
endpoint := "/collections/" + p.Alias
func (c *Client) DeleteCollection(alias string) error {
endpoint := "/collections/" + alias
env, err := c.delete(endpoint, nil /* data */)
if err != nil {
return err

6
collection_test.go
View File

@ -71,8 +71,7 @@ func TestCreateAndDeleteCollection(t *testing.T) {
t.Fatalf("Unable to create collection %q: %v", alias, err)
}
p := &DeleteCollectionParams{Alias: c.Alias}
if err := wac.DeleteCollection(p); err != nil {
if err := wac.DeleteCollection(c.Alias); err != nil {
t.Fatalf("Unable to delete collection %q: %v", alias, err)
}
}
@ -82,8 +81,7 @@ func TestDeleteCollectionUnauthenticated(t *testing.T) {
now := time.Now().Unix()
alias := fmt.Sprintf("test-collection-does-not-exist-%v", now)
p := &DeleteCollectionParams{Alias: alias}
err := wac.DeleteCollection(p)
err := wac.DeleteCollection(alias)
if err == nil {
t.Fatalf("Should not be able to delete collection %q unauthenticated.", alias)
}