From 7a2c93ae6d3ee91dbe7cdd9c68b3d20be43762a2 Mon Sep 17 00:00:00 2001 From: Matt Baer Date: Sun, 26 May 2019 14:08:05 -0400 Subject: [PATCH] Revert "DeleteCollection: Make params a struct" This reverts commit 1d34eede72c856b5aa9a31ed4036f42aed3111eb. --- collection.go | 10 ++-------- collection_test.go | 6 ++---- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/collection.go b/collection.go index 9d16e48..8c00a54 100644 --- a/collection.go +++ b/collection.go @@ -29,12 +29,6 @@ type ( Alias string `json:"alias"` Title string `json:"title"` } - - // DeleteCollectionParams holds the parameters required to delete a - // collection. - DeleteCollectionParams struct { - Alias string `json:"-"` - } ) // CreateCollection creates a new collection, returning a user-friendly error @@ -146,8 +140,8 @@ func (c *Client) GetUserCollections() (*[]Collection, error) { // anonymous. // // See https://developers.write.as/docs/api/#delete-a-collection. -func (c *Client) DeleteCollection(p *DeleteCollectionParams) error { - endpoint := "/collections/" + p.Alias +func (c *Client) DeleteCollection(alias string) error { + endpoint := "/collections/" + alias env, err := c.delete(endpoint, nil /* data */) if err != nil { return err diff --git a/collection_test.go b/collection_test.go index 905290e..93e82c7 100644 --- a/collection_test.go +++ b/collection_test.go @@ -71,8 +71,7 @@ func TestCreateAndDeleteCollection(t *testing.T) { t.Fatalf("Unable to create collection %q: %v", alias, err) } - p := &DeleteCollectionParams{Alias: c.Alias} - if err := wac.DeleteCollection(p); err != nil { + if err := wac.DeleteCollection(c.Alias); err != nil { t.Fatalf("Unable to delete collection %q: %v", alias, err) } } @@ -82,8 +81,7 @@ func TestDeleteCollectionUnauthenticated(t *testing.T) { now := time.Now().Unix() alias := fmt.Sprintf("test-collection-does-not-exist-%v", now) - p := &DeleteCollectionParams{Alias: alias} - err := wac.DeleteCollection(p) + err := wac.DeleteCollection(alias) if err == nil { t.Fatalf("Should not be able to delete collection %q unauthenticated.", alias) }