Source code for the WriteFreely SwiftUI app for iOS, iPadOS, and macOS
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

CONTRIBUTING.md 2.0 KiB

1234567891011121314151617181920212223242526272829303132333435363738
  1. # How to contribute
  2. We're happy you're considering contributing to the WriteFreely SwiftUI multiplatform app!
  3. Before making a contribution, please be sure to familiarize yourself with our contributor's [code of conduct](CODE_OF_CONDUCT.md).
  4. Otherwise, it won't take long to get up to speed on this. Here are our development resources:
  5. * We accept and respond to bugs here on [GitHub](https://github.com/writeas/writefreely-swiftui-multiplatform/issues).
  6. * We're usually in #writeas on freenode, but if not, find us on our [Slack channel](http://slack.write.as).
  7. ## Testing
  8. We try to write tests for all public methods in the codebase, but aren't there yet. While not required, including tests with your new code will bring us closer to where we want to be and speed up our review.
  9. ## Submitting changes
  10. Please send a [pull request](https://github.com/writeas/writefreely-swiftui-multiplatform/compare) with a clear list of what you've done.
  11. Please follow our coding conventions below and make sure all of your commits are atomic. Larger changes should have commits with more detailed information on what changed, any impact on existing code, rationales, etc.
  12. ## Coding conventions
  13. We strive for consistency above all. Reading the codebase should give you a good idea of the conventions we follow.
  14. * We use [SwiftLint](https://github.com/realm/SwiftLint) as a build script
  15. * We fix all warnings before committing anything (including linting warnings!)
  16. * We aim to document all public methods using Swift code documentation
  17. * Swift files are broken up into logical functional components
  18. ## Design conventions
  19. We maintain a few high-level design principles in all decisions we make. Keep these in mind while devising new functionality:
  20. * Updates should be backwards compatible or provide a seamless migration path from *any* previous version
  21. * Each method should perform one action and do it well
  22. * Each method will ideally work well in a script
  23. * Avoid clever functionality and assume each function will be used in ways we didn't imagine