#4 Fix text highlight color in dark mode

Zamknięty
otworzone 6 lat temu przez matt · 4 komentarzy
matt skomentował(-a) 6 lat temu

Right now when you select text in dark mode you can’t see what you’ve highlighted.

In my testing, this occurred on *buntu, but not on Elementary OS.

Right now when you select text in dark mode you can't see what you've highlighted. In my testing, this occurred on *buntu, but not on Elementary OS.
adrian skomentował(-a) 6 lat temu
Współpracownik

I attempted to use the appropriate selector (selection) for this in the CSS I’m applying to the textview, and it made no difference.

It’s worth noting in my theme this isn’t an issue as the text selection colour is blue, but if we’re taking over the styling there we should be ensuring the text selection colour contrasts enough to be visible.

I can look into this some more but that would probably take some time.

I attempted to use the appropriate selector (`selection`) for this in the CSS I'm applying to the textview, and it made no difference. It's worth noting in my theme this isn't an issue as the text selection colour is blue, but if we're taking over the styling there we should be ensuring the text selection colour contrasts enough to be visible. I can look into this some more but that would probably take some time.
matt dodał(-ęła) etykietę
high priority
5 lat temu
adrian skomentował(-a) 5 lat temu
Współpracownik

I tried several things, and I am not succeeding in getting the selection to show up.

Do you mind if I look into a way to remove the darkmode toggle button from the UI if the current theme doesn’t have one? Because it works when the theme defines a darkmode.

I tried several things, and I am not succeeding in getting the selection to show up. Do you mind if I look into a way to remove the darkmode toggle button from the UI if the current theme doesn't have one? Because it works when the theme defines a darkmode.
matt skomentował(-a) 5 lat temu
Właściciel

Nope, that works for me.

Nope, that works for me.
adrian skomentował(-a) 5 lat temu
Współpracownik

Fixed, though what I’ve managed to implement adds a couple seconds onto the startup time.

For performance it’d be better to reimplement a bit of GTK, though that risks getting the test wrong. The good thing about the approach I used is that it can withstand changes to GTK+.

Fixed, though what I've managed to implement adds a couple seconds onto the startup time. For performance it'd be better to reimplement a bit of GTK, though that risks getting the test wrong. The good thing about the approach I used is that it can withstand changes to GTK+.
adrian zamknął(-ęła) to zgłoszenie 5 lat temu
Zaloguj się, aby dołączyć do tej rozmowy.
Brak kamienia milowego
Brak przypisanych
Uczestnicy 2
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

To zgłoszenie nie ma w tej chwili żadnych zależności.

Ładowanie…
Nie ma jeszcze treści.