Fix text highlight color in dark mode #4

New Issue

matt · 2018-04-18T13:01:57Z

matt commented

2018-04-18 13:01:57 +00:00

Right now when you select text in dark mode you can't see what you've highlighted.

In my testing, this occurred on *buntu, but not on Elementary OS.

Right now when you select text in dark mode you can't see what you've highlighted. In my testing, this occurred on *buntu, but not on Elementary OS.

adrian commented

2018-04-18 22:45:57 +00:00

I attempted to use the appropriate selector (selection) for this in the CSS I'm applying to the textview, and it made no difference.

It's worth noting in my theme this isn't an issue as the text selection colour is blue, but if we're taking over the styling there we should be ensuring the text selection colour contrasts enough to be visible.

I can look into this some more but that would probably take some time.

I attempted to use the appropriate selector (`selection`) for this in the CSS I'm applying to the textview, and it made no difference. It's worth noting in my theme this isn't an issue as the text selection colour is blue, but if we're taking over the styling there we should be ensuring the text selection colour contrasts enough to be visible. I can look into this some more but that would probably take some time.

matt added the

high priority

label 2018-08-20 14:22:51 +00:00

adrian commented

2018-08-24 00:59:01 +00:00

I tried several things, and I am not succeeding in getting the selection to show up.

Do you mind if I look into a way to remove the darkmode toggle button from the UI if the current theme doesn't have one? Because it works when the theme defines a darkmode.

I tried several things, and I am not succeeding in getting the selection to show up. Do you mind if I look into a way to remove the darkmode toggle button from the UI if the current theme doesn't have one? Because it works when the theme defines a darkmode.

matt commented

2018-08-24 14:20:02 +00:00

Nope, that works for me.

adrian commented

2018-08-24 22:49:18 +00:00

Fixed, though what I've managed to implement adds a couple seconds onto the startup time.

For performance it'd be better to reimplement a bit of GTK, though that risks getting the test wrong. The good thing about the approach I used is that it can withstand changes to GTK+.

Fixed, though what I've managed to implement adds a couple seconds onto the startup time. For performance it'd be better to reimplement a bit of GTK, though that risks getting the test wrong. The good thing about the approach I used is that it can withstand changes to GTK+.

adrian closed this issue

2018-08-24 22:49:18 +00:00

Sign in to join this conversation.