matt/MMRA
1
0
Fork 0
mirror of https://github.com/thebaer/MMRA synced 2024-11-13 10:11:01 +00:00
Code Issues Releases Activity

Front-load images by constructing img elements

Browse Source 
instead of using `innerHTML` to create an element from text inside
`noscript` tags. This addresses as issue preventing Add-on acceptance
for Firefox (#4)
This commit is contained in:
Matt Baer 2017-09-13 22:58:10 -04:00
parent 92cd527e93
commit 24637b1b79
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
content.js
View File

@ -27,14 +27,22 @@ var hideDickbar = function() {
};
var disableLazyLoading = function() {
// Get all <noscript> tags accompanying dynamically-loading <img>s
var hiddenMedia = document.querySelectorAll('.js-progressiveMedia-inner');
if (hiddenMedia == null) {
return;
}
for (var i=0; i<hiddenMedia.length; i++) {
var template = document.createElement('template');
template.innerHTML = hiddenMedia[i].textContent;
hiddenMedia[i].parentNode.appendChild(template.content.firstChild);
// Create new <img> element from the one in <noscript> and add it in.
// This is certainly a roundabout way of doing things, but I didn't want to
// spend more time reverse-engineering Medium's lazy-loading code.
var img = document.createElement('img');
var srcMatch = hiddenMedia[i].textContent.match(/src="(https:\/\/[^"]+)"/);
if (srcMatch != null) {
img.src = srcMatch[1];
img.className = hiddenMedia[i].textContent.match(/class="([^"]+)"/)[1];
hiddenMedia[i].parentNode.appendChild(img);
}
}
};