Browse Source

Fix dangling goroutine on session expiration

The timer channel may already have been drained by `case <-timer.C`. In
this case, we need not to drain it again or we'll block forever.

To fix this, stop draining the timer channel. Since we're not going to
use the timer again anyway, it should be fine.
master
Simon Ser 4 years ago
parent
commit
e6e457e4a7
No known key found for this signature in database GPG Key ID: FDE7BE0E88F5E48
1 changed files with 1 additions and 3 deletions
  1. +1
    -3
      session.go

+ 1
- 3
session.go View File

@@ -237,9 +237,7 @@ func (sm *SessionManager) Put(username, password string) (*Session, error) {
}
}

if !timer.Stop() {
<-timer.C
}
timer.Stop()

s.locker.Lock()
if s.imapConn != nil {


Loading…
Cancel
Save