From f9c08a5b59a0f2412389a86419824be505529385 Mon Sep 17 00:00:00 2001 From: Gustavo Niemeyer Date: Tue, 1 Jul 2014 10:44:54 -0300 Subject: [PATCH] Fix Version.IsValid. Fixes #15. --- version.go | 2 +- version_test.go | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/version.go b/version.go index 1c2baec..f16f7fe 100644 --- a/version.go +++ b/version.go @@ -42,7 +42,7 @@ func (v Version) Contains(other Version) bool { } func (v Version) IsValid() bool { - return v == InvalidVersion + return v != InvalidVersion } var InvalidVersion = Version{-1, -1, -1} diff --git a/version_test.go b/version_test.go index c2971f1..887068d 100644 --- a/version_test.go +++ b/version_test.go @@ -106,3 +106,8 @@ func (s *VersionSuite) TestContains(c *C) { } } } + +func (s *VersionSuite) TestIsValid(c *C) { + c.Assert(InvalidVersion.IsValid(), Equals, false) + c.Assert(Version{0, 0, 0}.IsValid(), Equals, true) +}