From ed9d42974fb7b415e231a4300edd6bd0132e2f1d Mon Sep 17 00:00:00 2001 From: GeertJohan Date: Wed, 2 Apr 2014 21:51:40 +0200 Subject: [PATCH] Check for integer overflow in parseVersionPart --- version.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/version.go b/version.go index 2615b1f..f01c6da 100644 --- a/version.go +++ b/version.go @@ -91,9 +91,12 @@ func parseVersionPart(s string, i int) (part int, newi int) { } part *= 10 part += int(s[i] - '0') + if part < 0 { + return -1, -1 + } i++ if i+1 < len(s) && s[i] == '.' { - return part, i+1 + return part, i + 1 } } return part, i