Bladeren bron

Merge pull request #2 from GeertJohan/master

Handle version overflow better. Add missing return.
master
Gustavo Niemeyer 10 jaren geleden
bovenliggende
commit
22ed8eb873
3 gewijzigde bestanden met toevoegingen van 6 en 1 verwijderingen
  1. +1
    -0
      .gitignore
  2. +1
    -0
      main.go
  3. +4
    -1
      version.go

+ 1
- 0
.gitignore Bestand weergeven

@@ -0,0 +1 @@
/gopkg

+ 1
- 0
main.go Bestand weergeven

@@ -139,6 +139,7 @@ func handler(resp http.ResponseWriter, req *http.Request) {
repo.Version, ok = parseVersion(m[3]) repo.Version, ok = parseVersion(m[3])
if !ok { if !ok {
sendNotFound(resp, "Version %q improperly considered invalid; please warn the service maintainers.", m[3]) sendNotFound(resp, "Version %q improperly considered invalid; please warn the service maintainers.", m[3])
return
} }


repo.HubRoot = repo.GitRoot repo.HubRoot = repo.GitRoot


+ 4
- 1
version.go Bestand weergeven

@@ -91,9 +91,12 @@ func parseVersionPart(s string, i int) (part int, newi int) {
} }
part *= 10 part *= 10
part += int(s[i] - '0') part += int(s[i] - '0')
if part < 0 {
return -1, -1
}
i++ i++
if i+1 < len(s) && s[i] == '.' { if i+1 < len(s) && s[i] == '.' {
return part, i+1
return part, i + 1
} }
} }
return part, i return part, i


Laden…
Annuleren
Opslaan